Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coreapi importing #5921

Merged
merged 1 commit into from Apr 5, 2018

Conversation

gsvr
Copy link
Contributor

@gsvr gsvr commented Apr 5, 2018

Description

Closes #5918
Import coreapi from rest_framework.compat, not directly.

@DEKHTIARJonathan
Copy link

Please release a new version on PyPI as soon as this PR is merged ;)

Thanks for the work

@gsvr
Copy link
Contributor Author

gsvr commented Apr 5, 2018

@carltongibson I hope I opened this PR in the right way, first time contributing 😅
I did two additional things to what you stated in the issue:

  1. Added and coreschema is not None, not sure if this was necessary but it looked safer.
  2. Changed the import in test_renderers.py - I doubt this is necessary but it's more consistent with other imports in tests.

Please let me know if you want a test for this, it didn't look like something you were testing generally.

@carltongibson carltongibson added this to the 3.8.2 Release milestone Apr 5, 2018
@carltongibson
Copy link
Collaborator

carltongibson commented Apr 5, 2018

@gsvr Thanks for this.

@ALL: This will go into a 3.8.2. There are a couple of issues for that, so it'll be first half of next week. If you cannot wait until then you should install directly from GitHub. (Pip has first-class support for this. It's not something to avoid.)

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Looks good.

@carltongibson carltongibson merged commit 32caca4 into encode:master Apr 5, 2018
@gsvr
Copy link
Contributor Author

gsvr commented Apr 5, 2018

@carltongibson It's not a problem for me, I just pinned my version to <3.8 for now. Thanks for the quick responses :)

@carltongibson
Copy link
Collaborator

v3.8.2 is now available on PyPI. Thanks all.

@xordoquy
Copy link
Collaborator

xordoquy commented Oct 9, 2018

@LuisHCK please, don't use passive aggressive tone.
We - anyone that contributed here - have no part in your code not working as you'd have wished/expected.
You just don't bring anything valuable to the issue here beside negative comments.
Please, be constructive. Write the simplest possible test case where you can show your issue and open a PR so we may look at it.

@rpkilby
Copy link
Member

rpkilby commented Oct 9, 2018

@LuisHCK. These changes are included in the 3.8.2 release (see: here). I would check again what version of DRF is installed. You may also want to recreate your virtual environment.

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants