Potentially unplanned regression regarding ChoiceField and Enums #9388
Unanswered
tuchfarber
asked this question in
Potential Issue
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We're upgrading from 3.12.4 to 3.15.1 as part of a Django 3.2 to 4.2 upgrade. I believe there was a regression caused by this PR https://github.com/encode/django-rest-framework/pull/8955/files but I'm not sure if it is known/expected.
We have the following approximate setup:
The integers are the keys used internally, but the client passed the key of the enum to the view (
{"status": "unverified"}
). Previously this was working but the PR above broke it in favor of the opposite (passing thechoice.value
instead of thestr(choice)
). There seemed to be some concern around regressions and testing that didn't look like they were addressed in the PR, so I'm wondering if this regression is expected or if this is something that should be fixed.Thanks in advance!
Beta Was this translation helpful? Give feedback.
All reactions