You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
def list(self, request, *args, **kwargs):
queryset = self.filter_queryset(self.get_queryset())
page = self.paginate_queryset(queryset)
if page is not None:
serializer = self.get_serializer(page, many=True)
return self.get_paginated_response(serializer.data)
serializer = self.get_serializer(queryset, many=True)
return Response(serializer.data)
and make it like
def list(self, request, *args, **kwargs):
queryset = self.filter_queryset(self.get_queryset())
if not request.query_params.getlist("statuses"):
queryset.filter(current_status=Books.choices.PUBLISHED)
page = self.paginate_queryset(queryset)
if page is not None:
serializer = self.get_serializer(page, many=True)
return self.get_paginated_response(serializer.data)
serializer = self.get_serializer(queryset, many=True)
return Response(serializer.data)
@decorators.action(detail=False, methods=["get"])
def my_drafts(self, request, *args, **kwargs):
queryset = self.filter_queryset(self.get_queryset()).filter(submitter_user=request.user)
page = self.paginate_queryset(queryset)
if page is not None:
serializer = self.get_serializer(page, many=True)
return self.get_paginated_response(serializer.data)
serializer = self.get_serializer(queryset, many=True)
return Response(serializer.data)
But I feel like there should be a built in way in drf to reuse most of the code in the list from mixins without having to copy it. Of course I could make my own reusable method.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Is there anyway to make these 2 methods cleaner with drf?
https://github.com/encode/django-rest-framework/blob/master/rest_framework/mixins.py#L39
I could copy all code
and make it like
But I feel like there should be a built in way in drf to reuse most of the code in the list from mixins without having to copy it. Of course I could make my own reusable method.
Or is there already a built in way?
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions