Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest clippy has weird warning #423

Closed
rjzak opened this issue Apr 27, 2023 · 2 comments
Closed

Latest clippy has weird warning #423

rjzak opened this issue Apr 27, 2023 · 2 comments

Comments

@rjzak
Copy link
Member

rjzak commented Apr 27, 2023

The functions:

have parameters like ref cx: UserContext,, which are triggering this Clippy warning: almost_swapped. Best I can tell, that warning looks for code like: a = b; b = a;, which is not what's happening in these functions.

However, removing the ref keyword and using a & borrow instead causes the project to not build due to a trait error.

I suggest adding #![allow(clippy::almost_swapped)] to crates/server/src/lib.rs for the time being so other PRs may pass.

@rjzak
Copy link
Member Author

rjzak commented Apr 27, 2023

Possibly related rust-lang/rust-clippy#10421

@rjzak
Copy link
Member Author

rjzak commented Jun 2, 2023

@rjzak rjzak closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant