Allow labelFormat option to be a function
#1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 7b15d76 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b15d76:
|
Codecov Report
|
emmatown
reviewed
Nov 25, 2019
| if (typeof labelFormat === 'function') { | ||
| return labelFormat({ | ||
| name: sanitizedName, | ||
| filename |
There was a problem hiding this comment.
Could we call this path to distinguish it from the filename used in the string form of labelFormat?
emmatown
reviewed
Nov 25, 2019
Andarist
force-pushed
the
label-format-fn
branch
from
cf7c125
to
7b15d76
Compare
emmatown
approved these changes
Nov 25, 2019
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
* Allow `labelFormat` option to be a function * Change name of filename argument to path in function labelFormat
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1559