Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors shown in console using Firefox in debug build with speedy enabled #3111

Open
fredrikcarlbom opened this issue Oct 2, 2023 · 1 comment · May be fixed by #3150
Open

Errors shown in console using Firefox in debug build with speedy enabled #3111

fredrikcarlbom opened this issue Oct 2, 2023 · 1 comment · May be fixed by #3150

Comments

@fredrikcarlbom
Copy link

Current behavior:

In a debug build using speedy, using vendor specific css-prefixes such as webkit will cause errors to be written to the console in firefox.

To reproduce:

I don't succeed with a CodeSandbox-example since I can't figure out how to set speedy to true in that environment.

  1. Define a component using a vendor-specific prefix such as "::-webkit-scrollbar-track:hover{border-width:0.3125rem;background-color:rgba(255, 255, 255, 0.15625);}
  2. Set speedy true on the CacheProvider
  3. Do a non-production build
  4. Run the app in firefox
  5. An error like the following There was a problem inserting the following rule: "::-webkit-scrollbar-track:hover{border-width:0.3125rem;background-color:rgba(255, 255, 255, 0.15625);}" DOMException: An invalid or illegal string was specified

Expected behavior:

No errors in the console

Environment information:

"@emotion/react": "11.11.1",
"@emotion/styled": "11.11.0",
"react": "18.2.0",
"react-dom": "18.2.0",
@fredrikcarlbom
Copy link
Author

There is a some filtering on errors at sheet/src/index.js but it seems to focus on filtering out non chromium errors. Not sure if it is wanted to take browser into account when doing the filtering.

@silaslenz silaslenz linked a pull request Jan 17, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant