Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Stylis prefixer #2890

Merged
merged 4 commits into from Oct 27, 2022
Merged

Fork Stylis prefixer #2890

merged 4 commits into from Oct 27, 2022

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Sep 12, 2022

I'm not super happy about this but we need to upgrade Stylis to leverage some a fix for incorrect CSS variable prefixing. At the same time, we already get some grief about the included prefixer that prefixes flexbox by default (and more). I think that prefixing the grid would only compound the problem and I don't think that we actually want to prefix those properties (and we can't selectively control what gets prefixed and what doesn't).

cc @siriwatknp, this would fix your issue

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022

🦋 Changeset detected

Latest commit: e7bffcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/cache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e7bffcb:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #2890 (f8e94d3) into main (5ffa54a) will decrease coverage by 1.54%.
The diff coverage is 61.83%.

❗ Current head f8e94d3 differs from pull request most recent head d1d6fcd. Consider uploading reports for the commit d1d6fcd to get more accurate results

Impacted Files Coverage Δ
packages/cache/src/index.js 97.80% <ø> (ø)
packages/cache/src/prefixer.js 61.83% <61.83%> (ø)

@Andarist Andarist merged commit d8a13bc into main Oct 27, 2022
@Andarist Andarist deleted the fork-prefixer branch October 27, 2022 07:45
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
@siriwatknp
Copy link

siriwatknp commented Oct 27, 2022

this would fix your issue

@Andarist to be clear, what issue is it?

@Andarist
Copy link
Member Author

@siriwatknp this one: thysultan/stylis#301 . It got fixed in Stylis in September but I have only released an Emotion version with that fix just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants