Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address website feedback #2825

Merged
merged 6 commits into from Jul 19, 2022
Merged

Conversation

srmagura
Copy link
Member

@srmagura srmagura commented Jul 14, 2022

This addresses the four pieces of feedback that were left on #2805:

  • Make the remarkFixLinks plugin rewrite GitHub URLs, e.g.: https://github.com/emotion-js/emotion/tree/main/packages/babel-plugin/docs/@emotion/babel-plugin
  • Revert the tables I converted to HTML back to GFM tables, and add the remarkGfm plugin.
  • Slightly tweak the DocSearch styles to hopefully better match the rest of the site. Now it's pink rather than blue when you hover over it.
  • Add back .nvmrc with Node 16.

Also:

  • Remove style override I added that made non-live code blocks have large font.

@srmagura srmagura requested a review from Andarist July 14, 2022 13:43
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

⚠️ No Changeset found

Latest commit: dd8eff3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd8eff3:

Sandbox Source
Emotion Configuration

@srmagura srmagura merged commit b8d45d4 into emotion-js:main Jul 19, 2022
@srmagura srmagura deleted the website-improvements branch July 19, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant