Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all traces of Preact from the repository #2773

Merged
merged 4 commits into from Jun 7, 2022

Conversation

srmagura
Copy link
Member

@srmagura srmagura commented Jun 2, 2022

This was originally discussed here.

This PR is a stepping stone for the Yarn 3 upgrade. This is necessary because we depended on a really old version of Preact that Yarn 3 failed to install. (Yarn 3 upgrade is blocked by the website upgrade, btw. That is #2571.)

If anyone is using @emotion/styled with Preact, my changes to isPropValid will break them. But I kind of doubt @emotion/styled works with Preact in the first place so it should be fine. (?)

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

⚠️ No Changeset found

Latest commit: 133795c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@srmagura srmagura requested a review from Andarist June 2, 2022 21:42
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 133795c:

Sandbox Source
Emotion Configuration

Comment on lines -6 to -12
".emotion-0 {
color: red;
}

.emotion-1 {
width: 100%;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like those were actually working :p although I guess that there is no special handling for this in our code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, so yes the snapshots were working, though we were on a very old version of Preact and using preact-render-to-json which is now defunct AFAIK.

I guess, bottom line is, I don't see the need for Preact tests if Emotion doesn't support Preact.

@Andarist Andarist merged commit 62dd16b into emotion-js:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants