Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @definitelytyped/dtslint (attempt 2) #2772

Merged
merged 2 commits into from Jun 6, 2022

Conversation

srmagura
Copy link
Member

@srmagura srmagura commented Jun 2, 2022

Fixes #2735.

The first attempt at this was here. Though, that PR was targeting ts-migration. This time I have decided to target main. I will need to make a few tweaks after I merge this into ts-migration.

I removed the matrix strategy from our dtslint job in GitHub Actions. Before this change, we had 14 instances of the dtslint job, which each installed dependencies (2 minutes) and ran dtslint (20 seconds). With the new design, we will only install dependencies once, so a lot of duplicate work is being removed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

⚠️ No Changeset found

Latest commit: acb4e19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -221,7 +202,5 @@ jobs:
- name: Install Dependencies
run: yarn

- name: ESLint
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was here — we have a separate job for ESLint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye 👍 this even has already been removed on the ts-migration branch

@@ -125,9 +125,6 @@
"site",
"scripts/*",
"playgrounds/*"
],
"nohoist": [
"**/dtslint"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is no longer necessary — not sure what problem it was put in to solve.

@srmagura srmagura requested a review from Andarist June 2, 2022 21:22
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acb4e19:

Sandbox Source
Emotion Configuration

@Andarist Andarist merged commit 6f1f408 into emotion-js:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dtslint is unmaintained and causing issues
2 participants