New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to @definitelytyped/dtslint
(attempt 2)
#2772
Upgrade to @definitelytyped/dtslint
(attempt 2)
#2772
Conversation
|
@@ -221,7 +202,5 @@ jobs: | |||
- name: Install Dependencies | |||
run: yarn | |||
|
|||
- name: ESLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was here — we have a separate job for ESLint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye 👍 this even has already been removed on the ts-migration
branch
@@ -125,9 +125,6 @@ | |||
"site", | |||
"scripts/*", | |||
"playgrounds/*" | |||
], | |||
"nohoist": [ | |||
"**/dtslint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is no longer necessary — not sure what problem it was put in to solve.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit acb4e19:
|
Fixes #2735.
The first attempt at this was here. Though, that PR was targeting
ts-migration
. This time I have decided to targetmain
. I will need to make a few tweaks after I merge this intots-migration
.I removed the matrix strategy from our dtslint job in GitHub Actions. Before this change, we had 14 instances of the dtslint job, which each installed dependencies (2 minutes) and ran dtslint (20 seconds). With the new design, we will only install dependencies once, so a lot of duplicate work is being removed.