Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "no component selectors" error message #2727

Merged
merged 4 commits into from Apr 28, 2022

Conversation

srmagura
Copy link
Member

Closes #2705. To be clear, #2705 is a Next/swc issue, not an Emotion issue. I am just improving the error message so that people using the swc Emotion transform don't think they HAVE to use Babel.

The message now references the swc Emotion plugin which also supports
component selectors, like @emotion/babel-plugin.
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2022

🦋 Changeset detected

Latest commit: 41f8fe5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/serialize Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@srmagura srmagura requested a review from Andarist April 16, 2022 02:02
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41f8fe5:

Sandbox Source
Emotion Configuration
Emotion issue template Issue #2705

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #2727 (cb41e65) into main (409b237) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/serialize/src/index.js 100.00% <100.00%> (ø)

@Andarist
Copy link
Member

Could you add a short changeset (patch level) about this change?

@srmagura
Copy link
Member Author

Thanks for the reminder 👍

@Andarist Andarist merged commit 26e4e3e into emotion-js:main Apr 28, 2022
@github-actions github-actions bot mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component selectors can only be used in conjunction with babel-plugin-emotion error while running jest test
2 participants