Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abbr attribute to list of valid attributes #2621

Merged
merged 2 commits into from Jan 22, 2022

Conversation

andreasmcdermott
Copy link
Contributor

@andreasmcdermott andreasmcdermott commented Jan 22, 2022

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/th#attributes

What: Adding abbr attribute to allowlist.

Why: It is a valid attribute for th elements that is currently being removed when rendering with a component created using @emotion/styled. For more information about the abbr attribute: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/th#attributes

How: I added "abbr: true" to the allowlist.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete N/A
  • Changeset N/A

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2022

🦋 Changeset detected

Latest commit: 5209965

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@emotion/is-prop-valid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5209965:

Sandbox Source
Emotion Configuration

@andreasmcdermott andreasmcdermott marked this pull request as ready for review January 22, 2022 00:18
@Andarist Andarist merged commit d253163 into emotion-js:main Jan 22, 2022
@github-actions github-actions bot mentioned this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants