Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test setup of one of the SSR-related tests #2599

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

Andarist
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021

⚠️ No Changeset found

Latest commit: e002b8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e002b8c:

Sandbox Source
Emotion Configuration

Comment on lines +1 to +3
/**
* @jest-environment node
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the core of the fix, the generated snapshot without this was incorrect as Emotion was running in client-mode, so stuff from other tests slipped into another one

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2599 (e002b8c) into main (4a21258) will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/server/test/util.js 96.61% <100.00%> (ø)

@Andarist Andarist merged commit 169ac54 into main Dec 20, 2021
@Andarist Andarist deleted the fix/test-setup branch December 20, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant