Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/How
yarn install
in the Emotion repository fails on Windows if only Visual Studio 2022 is installed.scripts/benchmarks
depended onparcel@1.x.x
which depends ondeasync
which failed to build because it used a version ofnode-gyp
that didn't know about the new version of Visual Studio.react-native-web
than what was actually installed.react-native-web
and tweak benchmark app as necessary.yarn run-benchmark
fails with ERR_INVALID_REDIRECT when trying to access the web page.http-server
. Upgrade other dependencies for the sake of modernization.yarn run-benchmark
doesn't run againstemotion-styled
.emotion-styled
to the list of libraries to test.ssr-benchmark
which failed because it was CommonJS and it couldn't import the latest version ofd3-scale-chromatic
which is ESM.ssr-benchmark
code to ESM.ssr-benchmark
still fails because it is not passing a key tocreateCache
and because it is trying to read directly from a React context. It looks like this code hadn't been tested against Emotion 11 and recent versions of React.createCache
and useuseContext
.Why:
yarn install
and the benchmarks should work 😉Checklist: