Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Emotion website to the latest Gatsby or Next.js #2536

Closed
srmagura opened this issue Nov 1, 2021 · 3 comments · Fixed by #2805
Closed

Upgrade Emotion website to the latest Gatsby or Next.js #2536

srmagura opened this issue Nov 1, 2021 · 3 comments · Fixed by #2805
Assignees

Comments

@srmagura
Copy link
Member

srmagura commented Nov 1, 2021

The problem

Installing packages in the Emotion repository fails on an M1 Mac, see #2535.

Proposed solution

Upgrade the Emotion website to the latest version of Gatsby.

Alternative solutions

In the meantime, M1 Mac users can work around this by installing vips via Homebrew.

Additional context

I am planning to PR this eventually.

@srmagura srmagura changed the title Upgade Emotion website to the latest Gatsby Upgade Emotion website to the latest Gatsby or Next.js Nov 3, 2021
@srmagura srmagura changed the title Upgade Emotion website to the latest Gatsby or Next.js Upgrade Emotion website to the latest Gatsby or Next.js Nov 3, 2021
@srmagura
Copy link
Member Author

@Andarist I'll probably start on this next weekend. I am planning to use Next.js. A couple of points...

  1. Could you look into merging Optimize Carbon #2471?
  2. I want to write the new site in TypeScript, but I don't think that will work if I target the main branch since the site will need to import code written in Flow. So I'm planning on writing the new site in plain JS and then later adding types to it.
  3. Should I remove the BLM banner so we can close the issues and PRs that are complaining about it? (For the record, I think it is silly that people are bothered by it.)

@Andarist
Copy link
Member

  1. Don't bother about this. I can always rebase this later. This PR got a little bit stuck cause I had some conceptual problems with it. I think I had an idea how to simplify this later on but never got back to this PR
  2. Sounds OK. What code written in Flow will it import? If you refer to the sources of our packages then maybe running preconstruct watch in parallel (or just preconstruct build before Next) would do the trick and would allow you to not worry about the Flow stuff?
  3. I also think this is silly but yeah - I'm in favor of removing it now, it served its purpose for now.

@srmagura
Copy link
Member Author

Sounds good on all points. Yeah I just want to use @emotion/react like normal and I didn't realize that Next would use the compiled JS output instead of source files (since preconstruct does some kind of redirecty thing). I have it working now and it was no trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants