Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESBuild support (non-Babel-builds) #2474

Closed
205g0 opened this issue Sep 13, 2021 · 4 comments
Closed

ESBuild support (non-Babel-builds) #2474

205g0 opened this issue Sep 13, 2021 · 4 comments

Comments

@205g0
Copy link

205g0 commented Sep 13, 2021

Description:

Does emotion support ESBuilds envs such as vite.js? Looking around in the docs and issues for 10 mins and couldn't find anything. I assume not. Would be helpful to have an explicit statement right at the beginning and an outlook if this might a feature in the future and not

FWIW, Babel and stuff which come along with Babel feels to me like legacy tech which I just try to avoid. not sure who is using that stuff for new projects.

@205g0
Copy link
Author

205g0 commented Sep 13, 2021

emotion does support ESBuild envs, there's even some hack to make it even easier: https://dev.to/ajitsinghkamal/using-emotionjs-with-vite-2ndj

Should I keep this issue open or close? Wouldn't be too bad for emotion to promote that it works out of the box with everything and we could also integrate that hack from the above mentioned dev.to article...

@Andarist
Copy link
Member

Emotion would work "out of the box" with ESbuild if only that project would implement support for the "modern" JSX transform. There are some open issues about this:
evanw/esbuild#1172
evanw/esbuild#718

@agriffis
Copy link

Looks like evanw/esbuild#2349 will likely fix this when it's merged.

@hiddenest
Copy link

hiddenest commented Jul 29, 2022

Yeah, now it is merged (v0.14.51): evanw/esbuild#2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants