Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-preset-css-prop fails to put label when theme is typed #1785

Closed
escorponox opened this issue Mar 4, 2020 · 2 comments
Closed

babel-preset-css-prop fails to put label when theme is typed #1785

escorponox opened this issue Mar 4, 2020 · 2 comments

Comments

@escorponox
Copy link

Current behavior:

Classname has no label when we type the theme as explained in documentation.

To reproduce:

  1. Clone this repo: https://github.com/escorponox/emotion-babel-preset-report
  2. yarn
  3. Check the results

Expected behavior:
The styled component should have the label in the classname as configured in the babel-preset-css-prop

Environment information:

"emotion-theming": "^10.0.27",
"@emotion/core": "^10.0.21",
"@emotion/styled": "^10.0.17",
"react": "16.12.0",
"react-dom": "16.12.0"
@escorponox
Copy link
Author

image

@Andarist
Copy link
Member

This got fixed in #1220 and is already released as part of our upcoming v11. I'm afraid that we can't afford the time to backport this into v10, but I strongly encourage you to try out v11. Especially given the fact that its TS types got reworked from scratch and allow for typing Theme globally which should result in way fewer reasons to create your own wrappers around styled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants