Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-emotion-plugin not working with custom instances #1657

Closed
ivanbanov opened this issue Nov 28, 2019 · 2 comments
Closed

babel-emotion-plugin not working with custom instances #1657

ivanbanov opened this issue Nov 28, 2019 · 2 comments

Comments

@ivanbanov
Copy link

Seems like the custom instances are not working properly
I've reported it on xstyled repo (styled-components/xstyled#77) but perhaps it's related to the emotion plugin.
Also, when importing xstyled ThemeProvider using its own preset an error is happening, it may be related to the babel-plugin-jsx-pragmatic plugin

xstyled preset
https://github.com/smooth-code/xstyled/blob/master/packages/babel-preset-emotion-css-prop/src/index.js

is it anyhow related to the emotion plugins?

@Andarist
Copy link
Member

This got fixed in #1220 but this is going to be a part of upcoming v11, unfortunately we don't have time resources to backport this to v10.

@Andarist
Copy link
Member

Andarist commented Dec 3, 2019

Closing this because it has already been implemented in v11. Stay tuned for a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants