Switch away from actions-rs and minor CI improvements #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's mostly disjoined from actual building anyway and this makes it easier to follow what's going on.
The actions-rs organization is unmaintained with the sole member being unresponsive for close to two years. This commit switches form actions-rs/toolchain to dtolnay/rust-toolchain and from actions-rs/cargo to plain cargo commands.
It gets set as default during installation.
Merged
|
The CI failures are due to a regression in rustix 0.35.8. It fails to build for aarch64-linux-android. 0.35.7 compiles fine. |
|
Upstream issue: bytecodealliance/rustix#389 |
|
Thanks for tracking and filing the upstream issue with rustix. The resulting main.yml here looks shorter and cleaner. LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions-rs organization is unmaintained with the sole member being unresponsive for close to two years. Switch form actions-rs/toolchain to dtolnay/rust-toolchain and from actions-rs/cargo to plain cargo commands.
While at it, I've cleaned up the CI script a bit. Best reviewed on a commit by commit basis.
Note that updating actions/checkout to v3 has been intentionally left out here as a test case for dependabot. A PR adding a dependabot config will follow shortly.