New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix all warnings and some clippy lints #160
Conversation
2ccc2b8
to
105b0ae
Compare
I spent a lot of time to fix all rustc/clippy warnings, please take a look, thanks |
105b0ae
to
8d7a17a
Compare
I fix all clippy lints exclude this
|
8d7a17a
to
89668fb
Compare
Hi, thanks for the fixes. Can you please also test with rust 1.34 and rust 1.42? Some of the changes are not compatible with these older versions of rust, for example:
|
89668fb
to
d965c0a
Compare
sorry, both 1.34 and 1.42 could not compile on my computer due to other dependencies, so I could only wait CI to check 1.34 and 1.42 compile
|
Check the README for more info, but if you want to test with 1.34, you have to manually pin some of the dependencies to older versions that will work with 1.34:
|
seems my code is pass 1.34 and 1.42 rustc compile in CI, any other problem need I to solve? |
Thanks! I'll take a look in a few days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good here, except for 1 small issue on 32-bit linux. Thanks!
d965c0a
to
14094cf
Compare
14094cf
to
70014d0
Compare
Thanks! |
No description provided.