Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong variable name on Windows #2400

Merged
merged 2 commits into from Dec 6, 2022
Merged

Fix wrong variable name on Windows #2400

merged 2 commits into from Dec 6, 2022

Conversation

coderedart
Copy link
Contributor

I used rust analyzer's rename functionality and it seems the feature gated code is not affected by that.

I am surprised that the CI hasn't caught this one.

emilk
emilk approved these changes Dec 6, 2022
View reviewed changes
Copy link
Owner

@emilk emilk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a CI job for Windows… that's why. That should probably be fixed at some point

@emilk emilk merged commit 9145893 into emilk:master Dec 6, 2022
@emilk emilk changed the title fix wrong variable name Fix wrong variable name on Windows Dec 6, 2022
@emilk emilk mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coderedart @emilk