From 0913c77f3d9087a6011cae9ed287db59bb8aa7d5 Mon Sep 17 00:00:00 2001 From: Nolan Darilek Date: Mon, 25 Jul 2022 15:05:05 -0500 Subject: [PATCH] Make sliders correctly generate events on change. (#1854) --- egui/src/widgets/slider.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/egui/src/widgets/slider.rs b/egui/src/widgets/slider.rs index 467589d8fb4..d8c9a4010e2 100644 --- a/egui/src/widgets/slider.rs +++ b/egui/src/widgets/slider.rs @@ -327,9 +327,6 @@ impl<'a> Slider<'a> { self.set_value(new_value); } - let value = self.get_value(); - response.widget_info(|| WidgetInfo::slider(value, &self.text)); - if response.has_focus() { let (dec_key, inc_key) = match self.orientation { SliderOrientation::Horizontal => (Key::ArrowLeft, Key::ArrowRight), @@ -538,7 +535,9 @@ impl<'a> Widget for Slider<'a> { }; let mut response = inner_response.inner | inner_response.response; - response.changed = self.get_value() != old_value; + let value = self.get_value(); + response.changed = value != old_value; + response.widget_info(|| WidgetInfo::slider(value, &self.text)); response } }