IndexOutofBound panic during RemoveRoute()

[jeffreydwalter]

The issue referenced in #276 is not really fixed by the commit that was merged in.

There is still a panic here

go-restful/web_service.go

Line 190 in 1e8c63c

newRoutes[current] = w.routes[ix]

when you call RemoveRoute() with a route that is not in w.routes.

You can reproduce the issue with this code:

func main() {
	ws := new(WebService)
	ws.SetDynamicRoutes(true)
	ws.Route("GET", "/some/path")
	ws.RemoveRoute("/some/path/that/does/not/exist", "GET")
	ws.Routes()
}

I created a go playground that reproduces the issue here: https://play.golang.org/p/SYUMGQeY0cU

Changing RemoveRoute() to this fixes the issue:

func (w *WebService) RemoveRoute(path, method string) error {
	if !w.dynamicRoutes {
		return errors.New("dynamic routes are not enabled.")
	}
	w.routesLock.Lock()
	defer w.routesLock.Unlock()
	newRoutes := make([]Route, 0)
	for ix := range w.routes {
		if w.routes[ix].Method == method && w.routes[ix].Path == path {
			continue
		}
		newRoutes = append(newRoutes, w.routes[ix])
	}
	w.routes = newRoutes
	return nil
}

[jeffreydwalter]

I created a PR which includes the suggested fix here: #472

[emicklei]

thank you reporting this and providing a fix using the PR. I will review the changes and merge on approval.

[jeffreydwalter]

Fixed in PR #472.