Remove position property from Player
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: this property is hard to support for implementing players as a property they must keep up-to-date because it continuously changes over time measured in microseconds. Player#seeked() now takes the absolute position instead of a delta for consistency with the mpris interface and because we no longer store position on the player to do this calculation. The 'seeked' event on the Player now emits with the offset to seek only for a similar reason. add Player#getPosition() to be overridden by the user to be called whenver this property is gotten by the properties interface.
|
Breaking change. |
|
Indeed, makes sense. Thanks! |
|
Can you guys update the README with this new functionality? The example is not obvious enough, and I doubt people will be checking the source code and commit messages to get how this works. |
|
We should probably host the output of |
emersion
added a commit
that referenced
this pull request
Mar 5, 2019
|
Done in 26fcd12 |
This should probably come with the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: this property is hard to support for implementing players as
a property they must keep up-to-date because it continuously changes
over time measured in microseconds.
Player#seeked() now takes the absolute position instead of a delta for
consistency with the mpris interface and because we no longer store
position on the player to do this calculation.
The 'seeked' event on the Player now emits with the offset to seek only
for a similar reason.
add Player#getPosition() to be overridden by the user to be called
whenver this property is gotten by the properties interface.