Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastboot error with Embroider #489

Closed
puchesjr opened this issue Jun 30, 2020 · 6 comments
Closed

Fastboot error with Embroider #489

puchesjr opened this issue Jun 30, 2020 · 6 comments

Comments

@puchesjr
Copy link

puchesjr commented Jun 30, 2020

Started to migrate to Embroider using Prember and Ember-cli-fastboot

ember-cli-fastboot installed with ember install ember-cli-fastboot
prember installed with ember install prember

"@embroider/compat": "^0.19.0",
"@embroider/core": "^0.19.0",
"@embroider/router": "^0.19.0",
"@embroider/webpack": "^0.19.0",
"ember-cli-fastboot": "^2.2.3",
"prember": "^1.0.4",

Receiving this error during development build using ember s

@embroider/webpack (1)                   | 6626ms    
Babel: ember-cli-head (1)                | 1264ms    
@embroider/compat/app (1)                | 783ms     

App is being served by FastBoot
Error: �An incompatible version between `ember-cli-fastboot` and `fastboot` was found. Please update the version of fastboot library that is compatible with ember-cli-fastboot.�[39m�[22m
    at EmberApp.readPackageJSON (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/fastboot/src/ember-app.js:405:13)
    at new EmberApp (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/fastboot/src/ember-app.js:35:23)
    at FastBoot._buildEmberApp (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/fastboot/src/index.js:114:17)
    at new FastBoot (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/fastboot/src/index.js:52:10)
    at app.use (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/ember-cli-fastboot/index.js:335:29)
    at Layer.handle [as handle_request] (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/express/lib/router/index.js:317:13)
    at /Users/jrodkey/Projects/@now/ember-marketing/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/express/lib/router/index.js:335:12)
    at next (/Users/jrodkey/Projects/@now/ember-marketing/node_modules/express/lib/router/index.js:275:10)
@ef4
Copy link
Contributor

ef4 commented Jun 30, 2020

Sorry, this is a gotcha at the moment. We currently depend on a newer version of fastboot than any released version of ember-cli-fastboot uses.

If you’re using yarn you can use selective dependency resolution to get the newer fastboot directly like this:

"**/fastboot": "^3.1.0"

@puchesjr
Copy link
Author

Perfect! I wasn't sure if it was something we were doing incorrectly :) you can close this issue if you'd like.

@ef4
Copy link
Contributor

ef4 commented Jul 1, 2020

I'll leave this issue open until there's a release so other people are more likely to find it.

@abhilashlr
Copy link

abhilashlr commented Jul 6, 2020

Sorry, this is a gotcha at the moment. We currently depend on a newer version of fastboot than any released version of ember-cli-fastboot uses.

If you’re using yarn you can use selective dependency resolution to get the newer fastboot directly like this:

"**/fastboot": "^3.1.0"

Thanks for a temporary solution @ef4, and in case someone uses workspaces like me, you got to add this in the workspace package.json's resolutions key. I kept trying within my ember app and it never worked 😆

@kiwiupover
Copy link

https://github.com/GavinJoyce/embroider-spike/pull/19 @abhilashlr here is a working example of embroider and fastboot

@simonihmig
Copy link
Collaborator

FYI: there is a 3.0.0-beta.2 release meanwhile that comes with the latest fastboot dependency, and it fixed this issue here for me!

However it still doesn't work quite yet for me, now running into #160 it seems. Will comment over there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants