Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate using 'tagname' with the LinkTo component #767

Closed
MelSumner opened this issue Sep 23, 2021 · 3 comments
Closed

Deprecate using 'tagname' with the LinkTo component #767

MelSumner opened this issue Sep 23, 2021 · 3 comments

Comments

@MelSumner
Copy link
Contributor

MelSumner commented Sep 23, 2021

In general, the LinkTo component is useful, but there seems to be a leftover from the past.

image

This should be deprecated because it's confusing and also it lends itself to accessibility errors. The fewer footguns we provide in the accessibility space, the better.

If this is already deprecated, then the API docs need to be updated.

@bertdeblock
Copy link
Member

bertdeblock commented Sep 23, 2021

@chriskrycho
Copy link
Contributor

@MelSumner do you mind replacing the image here with the actual source from the docs? (Ironically, the image is inaccessible! 😅)

Also, for anyone curious, the current docs are here, and as @bertdeblock noted, this was deprecated as part of #707 – the deprecation info is here.

@locks
Copy link
Contributor

locks commented Sep 23, 2021

Closing as resolved! I was looking at LinkTo RFCs because I forgot about the Built-in components one 🤦

@locks locks closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants