Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent to RFC: Deprecate Libraries + Namespaces #540

Closed
pzuraq opened this issue Sep 5, 2019 · 5 comments
Closed

Intent to RFC: Deprecate Libraries + Namespaces #540

pzuraq opened this issue Sep 5, 2019 · 5 comments
Labels
Seeking Co-author T-deprecation T-framework RFCs that impact the ember.js library

Comments

@pzuraq
Copy link
Contributor

pzuraq commented Sep 5, 2019

  • Proposed Target: Ember v4.0.0
  • Alternative: ES Modules

Libraries and Namespaces are concepts that are leftover from the globals era of Ember. Before ES modules existed, we needed a common way to organize code that was meant to be shared and used cohesively with the rest of the framework. Libraries and namespaces provided a way to do this.

Today, these don't have any remaining uses. Removing them from the framework will reduce the overall size and complexity of Ember, without any major churn for existing users, and with minimal churn for some addons.

Migration Path

Any existing libraries that are still using the APIs will need to be updated, but most of their users should already be using ES modules. This will mostly be cleaning up existing code without major public API changes.

@pzuraq pzuraq added T-deprecation T-framework RFCs that impact the ember.js library Seeking Co-author labels Oct 8, 2019
@pzuraq pzuraq changed the title Pre-RFC: Deprecate Libraries + Namespaces Intent to RFC: Deprecate Libraries + Namespaces Oct 8, 2019
@locks locks added this to Deprecations in Deprecation Candidates Oct 9, 2019
@locks locks moved this from Deprecations to Yes in Deprecation Candidates Dec 7, 2020
@NullVoxPopuli
Copy link
Sponsor Contributor

did we do this? 🤔

@bertdeblock
Copy link
Member

Not yet.

@NullVoxPopuli
Copy link
Sponsor Contributor

I don't think we have any globals anymore though?

@wagenet
Copy link
Member

wagenet commented Jul 23, 2022

This does seem like something with doing. Possibly falls under #832

@wagenet
Copy link
Member

wagenet commented Jul 29, 2022

I'm going to go ahead and close this in favor of moving discussion to #832. We'll incorporate the work done on this issue into that RFC.

@wagenet wagenet closed this as completed Jul 29, 2022
Deprecation Candidates automation moved this from 4.0 to Finished Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Seeking Co-author T-deprecation T-framework RFCs that impact the ember.js library
Projects
No open projects
Development

No branches or pull requests

4 participants