Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

RFC #0332 - Tracking for Record Links & Meta #19

Closed
7 tasks
kategengler opened this issue Feb 12, 2019 · 3 comments
Closed
7 tasks

RFC #0332 - Tracking for Record Links & Meta #19

kategengler opened this issue Feb 12, 2019 · 3 comments
Assignees
Labels
needs planning:ember-data Needs planning by ember-data team team:ember-data ember-data team

Comments

@kategengler
Copy link
Member

kategengler commented Feb 12, 2019

RFC #0332 - Tracking for Record Links & Meta

Champion: @runspired


Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

Ember.js Team:

N/A

Ember CLI Team:

N/A

Ember Data Team:

Learning Team:

  • update the documentation to specify the differences between links and meta in json:api (potentially here)
  • make sure there is a section in the guides which specifies which types of store functions currently support meta & links (by the time this RFC is done I assume that they all would be supported?)
  • consider adding a section to API docs for each function to say if they support meta or not
  • consider adding explicit documentation about the potential name conflict and the default conflict resolution
  • update the Ember Data API docs with this feature
  • Make sure you can see meta as an attribute in Inspector (if we expect this to work)
  • Write a release blog post blurb

Steering Committee:

N/A

@mansona
Copy link
Member

mansona commented Apr 11, 2019

@runspired can we get an indication of how much of this has been done? I have just experimented with using links in a store.query() and it works as expected 🤔

@runspired
Copy link

@mansona this RFC is for record links & meta, not queries. Queries have indeed worked for some while.

@rwjblue rwjblue added needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:ember.js Needs planning by ember.js team needs planning:steering committee Needs planning by the steering committee and removed needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember.js Needs planning by ember.js team needs planning:steering committee Needs planning by the steering committee labels Apr 30, 2019
@kategengler kategengler moved this from Accepted to Planning in RFC Tracking May 10, 2019
@jenweber jenweber removed the needs planning:learning Needs planning by the learning team label May 31, 2019
@sdhull
Copy link

sdhull commented Apr 25, 2020

In terms of actually getting this done in Ember Data, is it basically just adding public meta?: Dict<any>; and then assigning it in the constructor? I still don't really grok the internals of ember data 😬

@locks locks closed this as completed May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs planning:ember-data Needs planning by ember-data team team:ember-data ember-data team
Projects
Development

No branches or pull requests

7 participants