[BUGFIX release] Add model hook in route blueprint #19860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/update-blueprints
branch
from
69915f3
to
7d85b93
Compare
When generating a route with a dynamic segment, say via:
ember g route foo --path="bar/:buzz_id"
The default empty route definition will cause an awkward assertion to be
thrown.
* In 3.28 without any data layer, the user is prompted via assertion to
implement a model hook.
* In 3.28 with Ember Data, an implicit fetch via Ember Data happens.
* In 4.0 without any data layer, the user would be prompted via
assertion to implement a model hook.
* In 4.0 with Ember Data, the user would be prompted via assertion to
either add a `find` method (old assertion) or to implement a model
hook (new assertion via
emberjs#19858).
It is doubtless that many users will still encounter these behaviors,
but updating the blueprints to generate a model hook by default improves
on the happy path.
In theory this could do back to 3.28, however the value there is
somewhat less since Ember Data's implicit store injection remains in
that version (and therefore the assertions/messages are less confusing).
mixonic
force-pushed
the
mixonic/update-blueprints
branch
from
7d85b93
to
e253e92
Compare
rwjblue
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a route with a dynamic segment, say via:
The default empty route definition will cause an awkward assertion to be thrown.
findmethod (old assertion) or to implement a model hook (new assertion via [BUGFIX release] Improve assert in default store #19858).It is doubtless that many users will still encounter these behaviors, but updating the blueprints to generate a model hook by default improves on the happy path.
In theory this could go back to 3.28, however the value there is somewhat less since Ember Data's implicit store injection remains in that version (and therefore the assertions/messages are less confusing) and is common.