Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove deprecated mouse events #19650

Merged
merged 1 commit into from Aug 20, 2021
Merged

Conversation

btecu
Copy link
Contributor

@btecu btecu commented Jul 18, 2021

@mixonic mixonic mentioned this pull request Jul 18, 2021
58 tasks
@mixonic
Copy link
Sponsor Member

mixonic commented Jul 18, 2021

@btecu I believe there are some test failures in here still.

@simonihmig
Copy link
Contributor

@btecu there are still tests failing here, and my recently merged changes related to the event dispatcher have caused merged conflicts here unfortunately. Do you still have time to work on this? Otherwise I could pick up your work here, and try to finish it.

@btecu btecu force-pushed the mouse branch 4 times, most recently from a92682d to 67599bf Compare August 18, 2021 04:28
@btecu
Copy link
Contributor Author

btecu commented Aug 18, 2021

@simonihmig I've rebased but yes, I'd appreciate the help with the failing test.

@nlfurniss
Copy link
Contributor

@simonihmig I've rebased but yes, I'd appreciate the help with the failing test.

I don't have access to push to your branch, but after applying this diff all tests pass:

diff --git a/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js b/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
index ff692ad05..5d5fb77ae 100644
--- a/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
+++ b/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
@@ -67,7 +67,7 @@ moduleFor(
 
       expectAssertion(() => {
         this.render(`{{#foo-bar}}{{/foo-bar}}`);
-      }, /You can not define `click,mouseEnter` function\(s\) to handle DOM event in the .* tagless component since it doesn't have any DOM element./);
+      }, /You can not define `click` function\(s\) to handle DOM event in the .* tagless component since it doesn't have any DOM element./);
     }
 
     ['@test throws an error if a custom defined event function is defined in a tagless component']() {

@simonihmig
Copy link
Contributor

All green now, awesome! 🎉
/cc @mixonic

@btecu
Copy link
Contributor Author

btecu commented Aug 18, 2021

@nlfurniss thank you!

@mixonic mixonic changed the title [CLEANUP] Remove deprecated mouse events [CLEANUP beta] Remove deprecated mouse events Aug 20, 2021
@mixonic mixonic merged commit a3a299c into emberjs:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants