[BUGFIX beta] assert <Input> and <Textarea>
#17733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have suggested (cc @gossi: either way, my suggestion would be to rename the component in your app asap) |
`input` and `textarea` are intended to be reserved component names, but the assertion was added to the wrong place. The end result is that only `(component "input")` and `(component "textarea")` were disallowed, but not when using the angle bracket syntax `<Input />` and `<Textarea />`. This compliments the existing tests in `contextual-components-test.js` (L1220).
wycats
force-pushed
the
built-in-asserts
branch
from
9a0c3fd
to
3a545cb
Compare
rwjblue
approved these changes
Mar 14, 2019
|
I'm not a blocker on this one. It's in my experimental octane/MU project. Assertion makes more sense to catch both invocations 👍 |
wycats
pushed a commit
that referenced
this pull request
Mar 15, 2019
[BUGFIX beta] assert `<Input>` and `<Textarea>` (cherry picked from commit c557721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputandtextareaare intended to be reserved component names, but the assertion was added to the wrong place. The end result is that only(component "input")and(component "textarea")were disallowed, but not when using the angle bracket syntax<Input />and<Textarea />.This compliments the existing tests in https://github.com/emberjs/ember.js/blob/master/packages/@ember/-internals/glimmer/tests/integration/components/contextual-components-test.js#L1220-L1230