[BUGFIX] Ensure tagForProperty works on class constructors #17691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Mar 2, 2019
pzuraq
force-pushed
the
bugfix/ensure-tag-for-property-works-on-classes
branch
from
af03e24
to
800dab3
Compare
added 2 commits
March 2, 2019 20:26
`tagForProperty` was returning the constant tag for functions, which meant it would return the constant tag for properties on class constructors. If a computed property was defined on the class constructor it would fail because of this.
pzuraq
force-pushed
the
bugfix/ensure-tag-for-property-works-on-classes
branch
from
800dab3
to
479a5d4
Compare
rwjblue
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagForPropertywas returning the constant tag for functions, whichmeant it would return the constant tag for properties on class
constructors. If a computed property was defined on the class
constructor it would fail because of this.
Fixes #17651