Add deprecation for Ember.$() #17489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated as per RFC386.
rwjblue
reviewed
Jan 18, 2019
| { | ||
| id: 'ember-views.curly-components.jquery-element', | ||
| until: '4.0.0', | ||
| url: 'https://emberjs.com/deprecations/v3.x#toc_jquery-apis', |
There was a problem hiding this comment.
Are we only going to have a single deprecation guide entry for all of the jQuery things, or a specific one for each deprecated "concept"
There was a problem hiding this comment.
Yes, I was planning to do that, as the (technically) different deprecations are very similar and related, and share the same explanation of why to deprecate them. My current draft is here: ember-learn/deprecation-app#255.
But if there is a reason to split them, we can do it!?
rwjblue
approved these changes
Jan 22, 2019
24 tasks
bendemboski
added a commit
to bendemboski/ember-ajax
that referenced
this pull request
Mar 22, 2019
Per https://github.com/emberjs/rfcs/blob/master/text/0386-remove-jquery.md#extend-emberjquery-package and emberjs/ember.js#17489, since this addon uses jquery, it should include `@ember/jquery` so `ember-cli-babel` doesn't transpile references to the `jquery` module into `Ember.$`.
bendemboski
added a commit
to bendemboski/ember-ajax
that referenced
this pull request
Mar 22, 2019
Per https://github.com/emberjs/rfcs/blob/master/text/0386-remove-jquery.md#extend-emberjquery-package and emberjs/ember.js#17489, since this addon uses jquery, it should include `@ember/jquery` so `ember-cli-babel` doesn't transpile references to the `jquery` module into `Ember.$`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated as per RFC386.