Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hooks from qunit-rfc-232 util-test blueprint #17340

Merged
merged 2 commits into from Dec 11, 2018
Merged

Remove Hooks from qunit-rfc-232 util-test blueprint #17340

merged 2 commits into from Dec 11, 2018

Conversation

hakubo
Copy link
Contributor

@hakubo hakubo commented Dec 11, 2018

It's not used
so a dev have to delete it by hand after generating a test

rwjblue
rwjblue reviewed Dec 11, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! I think you will also need to update the test fixtures we use (to fix the failing tests).

@rwjblue rwjblue merged commit 3d7cfff into emberjs:master Dec 11, 2018
@rwjblue
Copy link
Member

rwjblue commented Dec 11, 2018

Awesome, thank you!

@hakubo hakubo deleted the patch-1 branch December 11, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hakubo @rwjblue