Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TypeScript 3.0 #16907

Merged
merged 2 commits into from Aug 23, 2018
Merged

Upgrade to TypeScript 3.0 #16907

merged 2 commits into from Aug 23, 2018

Conversation

tomdale
Copy link
Member

@tomdale tomdale commented Aug 23, 2018

This PR upgrades broccoli-typescript-compiler to 4.0.1, which also upgrades the version of TypeScript to 3.0.

There was only one small breaking change, which is that TypeScript 2.9 changed keyof types to now include numbers and symbols in addition to strings. I updated these call signatures to extract just keys of type string to maintain the previous behavior.

krisselden
krisselden approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@krisselden krisselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I think we should move Opaque to unknown but that can be separate, also, anything that uses any | undefined | null should be {} | undefined | null or object | undefined | null as any is now really any,

@tomdale tomdale merged commit be60a70 into master Aug 23, 2018
@tomdale tomdale deleted the upgrade-typescript-3-0 branch August 23, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisselden krisselden krisselden approved these changes

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomdale @krisselden