[BUGFIX beta] Don't thread FactoryManager through createComponent #16854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chadhietala this is causing issues when using a custom component manager to create a component that has DI since the container isn't found on the “Attempting to lookup an injected property on an object without a container, ensure that the object was instantiated via a container.” I also don't understand why this logic needs to be different than how we handle instantiating components using the built in managers. |
|
@jordpo - The change here was the correct one to make, perhaps you can open an issue to discuss your specific scenario... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be exposing the FactoryManager to the Custom Component Manager. Instead just pass the factory e.g.
.classdirectly into the hook.