Added docs:upload task #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukemelia This is a good start, but I think we should put the docs repo somewhere public. We can then make the task pull down and update the repo locally and initiate a push to heroku, similar to what we do with the main website. |
|
@wagenet OK. Do you want to create emberjs-docs.github.com under emberis with language like "Ember.js Generated API Docs Website - All changes should be made at https://github.com/emberjs/ember.js" |
|
@lukemelia That seems fine to me for now. We can add instructions to the README for how to contribute to the docs. |
|
What's the status of this? |
|
I'd forgotten about it. Looks like it doesn't merge cleanly anymore. |
|
@lukemelia Could you rebase? |
|
Rebased. |
sandstrom
pushed a commit
to sandstrom/ember.js
that referenced
this pull request
Jun 17, 2021
…rn/ember-cli-3.22.0 Bump ember-cli from 3.21.2 to 3.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a rake task to generate and upload API docs. Requires setting a env var EMBER_DOCS_UPLOAD_PATH