Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ember-auto-import >= 2 or higher with ember-source@4.0.0 #19752

Closed
rwjblue opened this issue Sep 15, 2021 · 1 comment · Fixed by #19761
Closed

Require ember-auto-import >= 2 or higher with ember-source@4.0.0 #19752

rwjblue opened this issue Sep 15, 2021 · 1 comment · Fixed by #19761
Labels
Milestone

Comments

@rwjblue
Copy link
Member

rwjblue commented Sep 15, 2021

In order to allow ember-source to migrate to be a V2 addon, we must require that ember-auto-import@2 is present in the consuming application.

Concretely, we should add code to the addon entry point to check this.project.addons includes ember-auto-import@2 installed. That code would go somewhere around here:

init() {

@rwjblue rwjblue added this to the 4.0 milestone Sep 15, 2021
snewcomer added a commit to snewcomer/ember.js that referenced this issue Sep 22, 2021
snewcomer added a commit to snewcomer/ember.js that referenced this issue Sep 22, 2021
snewcomer added a commit to snewcomer/ember.js that referenced this issue Sep 22, 2021
ef4 added a commit that referenced this issue Sep 24, 2021
kategengler pushed a commit that referenced this issue Oct 11, 2021
Closes #19752

(cherry picked from commit 8757165)
@sandydoo
Copy link
Contributor

sandydoo commented Oct 13, 2021

@rwjblue, I’ve noticed that, as a side-effect of this, addons will have to include ember-auto-import >= 2 as a dependency to run tests against ember >= 4 (even if they don’t use it). I haven’t seen a discussion around this in the run-up to v4, and I have a sneaking feeling this might come as a surprise to a lot of addon maintainers. Might it be worth releasing some guidance on this with the release?

As an alternative to forcing all apps downstream to use auto-import v2, I’m probably going to be taking advantage of ember-try scenarios for the next while. Or as long as the test suite has a version of ember <4. sandydoo/ember-google-maps@3c78cba

Update

Found this comment #19761 (comment). Luckily, the devDependencies option works in my case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants