[BUGFIX release] Revert lazy hash changes #19594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
approved these changes
Jun 8, 2021
rwjblue
approved these changes
Jun 9, 2021
|
There is one strange issue I am seeing with these changes reverted. An input loses focus and the active element becomes the body when updating query params. Verified bug on 3.27.4 but not 3.27.3. I could put together an example repro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of BUGFIX release landed on the 3.27 release channel in an attempt to restore the previous lazy behavior. This is still desirable, but unfortunately the fixes caused other regressions. We have a new approach in mind that should be more compatible, but at this point, we have gone through a lot of changes with not a lot of time to test the approaches in the real world.
So the decision is to revert all of the related fixes on 3.27. This would restore the 3.26 buggy behavior, which was already broken since early 3.2x releases. We will land the new fix on 3.28 instead and let it go through a full beta cycle in order to access any real world impact properly.