Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some components with numbers in the name don't work with Angle Brackets #17549

Closed
jenweber opened this issue Feb 2, 2019 · 4 comments · Fixed by #17552
Closed

Some components with numbers in the name don't work with Angle Brackets #17549

jenweber opened this issue Feb 2, 2019 · 4 comments · Fixed by #17552

Comments

@jenweber
Copy link
Contributor

jenweber commented Feb 2, 2019

As reported by @gmartell, if you have a number in a component name, it fails to be found if used with Angle Bracket invocation. It seems like a component number1-problem is ok as <Number1-Problem /> but fails as <Number1Problem />.

Minimal reproduction

@maxwondercorn
Copy link

Issue is specifically converting ember-c3 to angle bracket invocation. Working invocation

{{c3-chart
  data=this.computedData
  size=@size
  axis=this.axis
  color=this.color
  point=this.point
  zoom=this.zoom
}}

converted to angle brackets

<C3Chart
  @data={{this.computedData}}
  @size={{@size}}
  @axis={{this.axis}}
  @color={{this.color}}
  @point={{this.point}}
  @zoom={{this.zoom}}
/>

This generates Error: Compile Error: Cannot find component c3chart from the opcode compiler.

I've tried some camelcase variations and either get the same error message or TypeError: func is not a function. (In 'func(exp, builder)', 'func' is undefined)

@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2019

@jenweber jenweber changed the title Some components with numbers in them don't work with Angle Brackets Some components with numbers in the name don't work with Angle Brackets Feb 2, 2019
@jenweber
Copy link
Contributor Author

jenweber commented Feb 2, 2019

I'm having a look at this issue.

@jenweber
Copy link
Contributor Author

jenweber commented Feb 2, 2019

PR #17552

kategengler pushed a commit that referenced this issue Feb 5, 2019
Previously, c3-plot would not work when invoked as <C3Plot />.
Now it will resolve correctly.
Closes #17549

(cherry picked from commit 6cd0258)
kategengler pushed a commit that referenced this issue Feb 6, 2019
Previously, c3-plot would not work when invoked as <C3Plot />.
Now it will resolve correctly.
Closes #17549

(cherry picked from commit 6cd0258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants