Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse enter/leave event not firing with "jquery-integration": false #16922

Closed
amk221 opened this issue Aug 30, 2018 · 5 comments
Closed

Mouse enter/leave event not firing with "jquery-integration": false #16922

amk221 opened this issue Aug 30, 2018 · 5 comments

Comments

@amk221
Copy link
Contributor

amk221 commented Aug 30, 2018

The enter/leave events don't always fire.

I think it has something to do with the component having a child component in it (a link-to, in this GIF):

Here is a demo repo
https://github.com/amk221/-ember-jquery-mouse-events#example

@kennethlarsen
Copy link
Member

Related to this? #16603

@amk221
Copy link
Contributor Author

amk221 commented Aug 30, 2018

Yeh related (I linked to that in the demo repo). But that fix is merged in?

@amk221
Copy link
Contributor Author

amk221 commented Sep 17, 2018

I imagine this will prevent some people from ditching jQuery, could we a bug label on this?

simonihmig added a commit to simonihmig/ember.js that referenced this issue Sep 23, 2018
The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in emberjs#16922.

Related to 16603
Fixes emberjs#16922
@simonihmig
Copy link
Contributor

Here's a fix: #16999
Thanks @amk221 for the reproduction demo!

@amk221
Copy link
Contributor Author

amk221 commented Sep 23, 2018

@simonihmig fantastic, thank you

simonihmig added a commit to simonihmig/ember.js that referenced this issue Sep 23, 2018
The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in emberjs#16922.

Related to 16603
Fixes emberjs#16922
kategengler pushed a commit that referenced this issue Sep 25, 2018
The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in #16922.

Related to 16603
Fixes #16922

(cherry picked from commit 6264318)
kategengler pushed a commit that referenced this issue Sep 25, 2018
The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in #16922.

Related to 16603
Fixes #16922

(cherry picked from commit 6264318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants