From 2e3ad645f677af010a7d7916efac98d1b011cd1b Mon Sep 17 00:00:00 2001 From: Robert Jackson Date: Thu, 12 Nov 2020 11:16:57 -0500 Subject: [PATCH] Remove `@dependentKeyCompat` assertion. The assertion helps prevent double work, but does not prevent application errors/bugs (other than poor performance). This removes the assertion and is intended for release in 3.22.2 and 3.20.7. (cherry picked from commit 118f0f65ce2d2c09945e62755dde84454045ca72) --- packages/@ember/object/compat.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/packages/@ember/object/compat.ts b/packages/@ember/object/compat.ts index dc429f3135e..53bfafc5039 100644 --- a/packages/@ember/object/compat.ts +++ b/packages/@ember/object/compat.ts @@ -2,21 +2,15 @@ import { Meta } from '@ember/-internals/meta'; import { Decorator, DecoratorPropertyDescriptor, - descriptorForProperty, isElementDescriptor, setClassicDecorator, } from '@ember/-internals/metal'; import { assert } from '@ember/debug'; import { consumeTag, tagFor, track, UpdatableTag, updateTag } from '@glimmer/validator'; -let wrapGetterSetter = function (target: object, key: string, desc: PropertyDescriptor) { +let wrapGetterSetter = function (_target: object, key: string, desc: PropertyDescriptor) { let { get: originalGet } = desc; - assert( - 'You attempted to use @dependentKeyCompat on a property that already has been decorated with either @computed or @tracked. @dependentKeyCompat is only necessary for native getters that are not decorated with @computed.', - descriptorForProperty(target, key) === undefined - ); - if (originalGet !== undefined) { desc.get = function () { let propertyTag = tagFor(this, key) as UpdatableTag;