You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: the main branch will not be releasable during this time, because we need to complete the plan, so that there is minimal/zero disruption to folks' test suites.
release another v3 version, since the types fix is still unreleased.
we should keep changes on this branch to the bare minimum, as we don't want to need to sync back to main unless we really have to.
NOTE that the v3 branch is a snapshot of what this repo looked like before everything is this quest issues started happening
update README so that folks can discover how to best ensure only one copy of @ember/test-waiters is present across all their dependencies (which won't be required for the waiter system to work, but will be required to get improvements across the whole dep graph)
add notes for addon authors to utilize peerDependencies with @ember/test-waiters (with permissive range, which would be allowed post-globalThis usage) with state held on globalThis, we don't need peerDependencies, we can allow duplicates of test-waiters. Using dependencies instead of peerDependencies can help make installation experience smoother for folks, however everyone should end up having @ember/test-waiters declared in their apps anyway.
note that peers however help with install time and debugging but won't be necessary for things to work.
release new version of ember-test-waiters that re-exports everything from @ember/test-waiters
this is needed because some super old projects import from ember-test-waiters, and if someone is using v4 of test waiters, yet part of their dep graph uses the super old ember-test-waiters, we may want to do this to allow users control over which @ember/test-waiters their deep dep of ember-test-waiters is using.
We may also want to "wait and see" if this problem even exists.
NOTE: the
main
branch will not be releasable during this time, because we need to complete the plan, so that there is minimal/zero disruption to folks' test suites.Here is a preview of what's in the next major:
In order of blockers:
we should keep changes on this branch to the bare minimum, as we don't want to need to sync back to
main
unless we really have to.NOTE that the v3 branch is a snapshot of what this repo looked like before everything is this quest issues started happening
Can happen in any order
Add 4 empty test apps (all boilerplate) #460
move tests to base-tests app, drop support for 3.8, 3.12, 0.x embroider, and ember-classic #463
Add support for ember-concurrency@v3 #465
ComputedProperty
which is different from the built-in types)Move ember-concurrency-specific-tests to the ember-concurrency@v2 test-app #464
ember-fetch@v8
main
branch -- already implemented a long time ago viagetGlobal
and storing theWAITERS
onglobalThis
.@ember/test-waiters
to a native packageWAITERS
' keys. (allows deleting code)@ts-ignore
from the test-appsfetch
-- coordinate with Maintenance, V2, modernfetch
, etc ember-cli/ember-fetch#738@ember/test-waiters
is present across all their dependencies (which won't be required for the waiter system to work, but will be required to get improvements across the whole dep graph)add notes for addon authors to utilizewith state held onpeerDependencies
with@ember/test-waiters
(with permissive range, which would be allowed post-globalThis
usage)globalThis
, we don't needpeerDependencies
, we can allow duplicates of test-waiters. Usingdependencies
instead ofpeerDependencies
can help make installation experience smoother for folks, however everyone should end up having@ember/test-waiters
declared in their apps anyway.ember-test-waiters
that re-exports everything from@ember/test-waiters
this is needed because some super old projects import from ember-test-waiters, and if someone is using v4 of test waiters, yet part of their dep graph uses the super old ember-test-waiters, we may want to do this to allow users control over which
@ember/test-waiters
their deep dep ofember-test-waiters
is using.We may also want to "wait and see" if this problem even exists.
ember-test-waiters
as deprecatedhttps://www.npmjs.com/package/ember-test-waiters
The text was updated successfully, but these errors were encountered: