Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Remove the index signature from TestContext #1302

Merged
merged 1 commit into from Dec 21, 2022
Merged

[backport] Remove the index signature from TestContext #1302

merged 1 commit into from Dec 21, 2022

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Dec 21, 2022 •
edited

This incorporates the same basic fix for isRenderingTestContext as the original (#1301) does for isTestContext, since that mechanic changes between v2 and v3.

@chriskrycho chriskrycho changed the title Remove the index signature from TestContext [backport] Remove the index signature from TestContext Dec 21, 2022
@chriskrycho chriskrycho mentioned this pull request Dec 21, 2022
Merged
@dfreeman @chriskrycho
Remove the index signature from TestContext
a34c29b 
This incorporates the same basic fix for `isRenderingTestContext` as
the original does for `isTestContext`, since that mechanic changes
between v2 and v3.

(cherry picked from commit cba01be)
@chriskrycho chriskrycho merged commit 6675e10 into v2-x Dec 21, 2022
@chriskrycho chriskrycho deleted the backport-fix branch December 21, 2022 16:19
@eugenioenko
Copy link

eugenioenko commented Dec 22, 2022 •
edited

Because the type BaseContext was switched here from a dictionary to an object I'm seeing this type errors in the integration tests

Property 'element' does not exist on type 'TestContext' when accessing it with this.element?.textContent.

Make sense, element doesn't exist in type object, and the TestContext that inherits from BaseContext doesn't define the element property.

And yet, element is definitely a property in TestContext.

@eugenioenko eugenioenko mentioned this pull request Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chriskrycho @eugenioenko @dfreeman