Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @ember/test-waiters to 3.0.0 #1109

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Aug 18, 2021

  • @emberjs/test-waiters
  • add ember-source 3.24 to ember-try

@scalvert scalvert changed the title upgrade @ember/test-waiters Upgrade @ember/test-waiters to 3.0.0 Aug 18, 2021
@stefanpenner stefanpenner added the dependencies Pull requests that update a dependency file label Aug 18, 2021
@scalvert scalvert requested review from scalvert and rwjblue August 18, 2021 21:01
Copy link
Contributor

@scalvert scalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the 3.24 scenario!

@stefanpenner stefanpenner merged commit 9d258f9 into master Aug 18, 2021
@stefanpenner stefanpenner deleted the update-test-waiters branch August 18, 2021 21:29
@Turbo87
Copy link
Member

Turbo87 commented Aug 19, 2021

@stefanpenner this appears to be a breaking change (see rust-lang/crates.io#3840). we are using ember-cli-dependency-lint to avoid having multiple versions of the same addon in the app, and now we have two different major versions of @ember/test-waiters that can't be deduplicated.

@scalvert
Copy link
Contributor

Hey @Turbo87, @ember/test-waiters has a mechanism that dedupes that dependency at build time, which helps ensure you only have one version at any time in your project. Is this manifesting as an actual issue, or are you just anticipating this based on how current ember-cli build dedupes work?

@stefanpenner
Copy link
Member Author

stefanpenner commented Aug 19, 2021

@Turbo87 yes, it is a major version...

More specifically, if you have code that enforces non-duplicated dependencies, that code most be flexible enough to allow periodic divergences. Otherwise you require the ecosystem to lock-step upgrade dependencies at each major version, which isn't possible.

@scalvert
Copy link
Contributor

scalvert commented Aug 19, 2021

I think you can accommodate this dependency using:

// config/dependency-lint.js
module.exports = {
  allowedVersions: {
    '@ember/test-waiters': '*'
  }
};

@Turbo87
Copy link
Member

Turbo87 commented Aug 19, 2021

@scalvert TIL, thank you. I've opened salsify/ember-cli-dependency-lint#22 to adjust the default list of allowedVersions in that linter.

backspace added a commit to cardstack/cardstack that referenced this pull request Aug 19, 2021
Thanks to @Aierie for pointing me to this:
ca1ea21

I first tried this to no avail, #JustMonorepoThings? 🤔
emberjs/ember-test-helpers#1109 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants