-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @ember/test-waiters to 3.0.0 #1109
Conversation
df59581
to
19dc9fc
Compare
19dc9fc
to
5eab397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the 3.24 scenario!
@stefanpenner this appears to be a breaking change (see rust-lang/crates.io#3840). we are using ember-cli-dependency-lint to avoid having multiple versions of the same addon in the app, and now we have two different major versions of |
Hey @Turbo87, |
@Turbo87 yes, it is a major version... More specifically, if you have code that enforces non-duplicated dependencies, that code most be flexible enough to allow periodic divergences. Otherwise you require the ecosystem to lock-step upgrade dependencies at each major version, which isn't possible. |
I think you can accommodate this dependency using: // config/dependency-lint.js
module.exports = {
allowedVersions: {
'@ember/test-waiters': '*'
}
}; |
@scalvert TIL, thank you. I've opened salsify/ember-cli-dependency-lint#22 to adjust the default list of |
Thanks to @Aierie for pointing me to this: ca1ea21 I first tried this to no avail, #JustMonorepoThings? 🤔 emberjs/ember-test-helpers#1109 (comment)
@emberjs/test-waiters