Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Disable Linting" checkbox does nothing #1139

Open
nelstrom opened this issue Sep 26, 2023 · 2 comments
Open

The "Disable Linting" checkbox does nothing #1139

nelstrom opened this issue Sep 26, 2023 · 2 comments

Comments

@nelstrom
Copy link
Contributor

In the test runner, we have a "Disable Linting" checkbox:

qunit-nolint

After creating a brand new Ember app (via ember new), I noticed that the "Disable Linting" checkbox has no effect. Whether it's checked or unchecked, linting doesn't happen inside the test runner.

@NullVoxPopuli
Copy link
Sponsor Collaborator

I think the checkbox only ever did anything if you had ember-cli-eslint or ember-cli-template-lint -- do you have either of those?

If not, we should probs find a way to remove that checkbox!

Thanks for reporting!

@nelstrom
Copy link
Contributor Author

Ah right! ember-cli-eslint and ember-cli-template-lint are both marked as deprecated.

As I see it, there's two ways of doing this. Either:

  1. Remove the "Disable Linting" checkbox, and strip out any dead code that handles that functionality
  2. OR remove the checkbox, but leave the code that implements that functionality, and add some documentation somewhere on how to add the checkbox back for anyone that misses it

Either way, I think the checkbox needs to go. It's squatting on some valuable real-estate.

I've had a go at removing the checkbox in #1140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants