Asserting error thrown no longer works as of 2.11.3

[jasonmit]

Unsure where the proper fix belongs, but I believe it surfaced as part of:
emberjs/ember.js#14898

Example of test that now fails since the assertion is not handled by mocha/chai before the error is thrown:

it('x-foo throws on initialization if no model is provided', function() {
  expect(() => {
    this.render(hbs`{{x-foo}}`);
  }).to.throw('model attribute must be provided to x-foo');
});

[Turbo87]

@workmanw @rwjblue any comments?

[Turbo87]

okay, so I got several opinions on this:

• expect().to.throw() is provided by Chai and https://github.com/ember-cli/ember-cli-chai, so if that was broken the issue should be fixed over there
• expect().to.throw() is not broken since it works very well when you put e.g. throw new Error('foo') inside of it
• if this.render() threw previously, but is not throwing anymore then that is an API change of Ember itself

[Turbo87]

this seems to be an issue in Ember itself, so I'll close the issue here for now in favor of emberjs/ember.js#15013