Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify ember_debug's usage of owner vs _application #1199

Open
rwjblue opened this issue May 11, 2020 · 2 comments · May be fixed by #2557
Open

Unify ember_debug's usage of owner vs _application #1199

rwjblue opened this issue May 11, 2020 · 2 comments · May be fixed by #2557
Labels
bug

Comments

@rwjblue
Copy link
Member

rwjblue commented May 11, 2020

Currently, EmberDebug uses owner in our own tests, but in production we always use _application.__deprecatedInstance__. This split is kinda bad to begin with but it also prevents issues with using the ember-inspector while running an Apps own tests.
@rwjblue rwjblue added the bug label May 11, 2020
@RobbieTheWagner
Copy link
Member

@patricklx I'm unsure if this issue still needs to be addressed? I know you have heavily refactored a lot of this, so perhaps we can close this?

@patricklx
Copy link
Collaborator

it's still testing with owner in our own tests

@patricklx patricklx linked a pull request Feb 12, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not handle is testing patricklx/ember-inspector
3 participants
@rwjblue @patricklx @RobbieTheWagner