Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to track performance of tracking chain revalidation #1594

Open
lifeart opened this issue May 19, 2021 · 0 comments
Open

Ability to track performance of tracking chain revalidation #1594

lifeart opened this issue May 19, 2021 · 0 comments

Comments

@lifeart
Copy link
Contributor

lifeart commented May 19, 2021

Inputs:

Angular devtools has ability to track change-detection performance:

https://blog.angular.io/introducing-angular-devtools-2d59ff4cf62f

image

Idea is:

Land similar DX for Ember.js developers users.

As mentioned in: https://discord.com/channels/480462759797063690/486243207072710656/844590207331729449

We should figure out most interesting/easy parts to implement.

Feature:

We could start with tracking chain revalidation logging at application level using builtin browser performance API.

Like a:

revalidate() {
    performance.mark(`revalidation-start-${epoch}`);
    glimmerInternals.revalidate();
    performance.mark(`revalidation-finished-${epoch}`);
}

using this markers we could collect time, spend on it.

Also, it will be great to have same marks per component revalidation, wondering could we have a special opcode for it, or it could be hooked somehow in current pipeline?

appreciate for any inputs or ideas on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant