Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Child"/"Children" words are lowercased on singularize/pluralize. #135

Open
arnaudbesnier opened this issue Oct 13, 2017 · 4 comments
Open

Comments

@arnaudbesnier
Copy link

arnaudbesnier commented Oct 13, 2017

pluralize('car') // => cars
pluralize('Car') // => Cars
singularize('cars') // => car
singularize('Cars') // => Car

// So far, so good...

pluralize('child') // => children
pluralize('Child') // => children # why lowercased?
singularize('children') // => child
singularize('Children') // => child # why lowercased?

Using version 2.0.1.

@arnaudbesnier
Copy link
Author

@fsmanuel
Copy link
Contributor

@arnaudbesnier the thing with child is that it's an irregular and it's registered lowercase. The regular rules aren't registered but use regex to replace or add the singular/plural form.

@arnaudbesnier arnaudbesnier changed the title Child/Children are lowercased on singularize/pluralize. "Child"/"Children" words are lowercased on singularize/pluralize. Oct 13, 2017
@arnaudbesnier
Copy link
Author

arnaudbesnier commented Oct 13, 2017

@fsmanuel thanks for your response, that's what I discovered about child.
Do we agree that this is a bug? I probably don't know all the constraints.

Not sure to understand how to bypass this issue.
Can you share an example of code I should add to have the expected behaviour?

@fsmanuel
Copy link
Contributor

fsmanuel commented Oct 13, 2017

@arnaudbesnier personally I think it is a bug but I'm not sure how we deal with it. I'll open a PR with failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants